Add loop and other control flow expressions #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
added
A-api
Niki4tap
reviewed
Mar 4, 2023
No problem at all, thank you for providing feedback!! I have a busy week ahead. So, it might take some time until I address the comments :)
That's totally fine. The docs and API are the important parts. I find the rustc backend a bit chaotic. While working on it, I also focus on the tests. That's what they're for. So feel free to continue handling it like that :). |
Co-authored-by: Niki4tap <rombiklol2@gmail.com>
xFrednet
force-pushed
the
052-more-control-more-control
branch
from
514254f
to
8d6f2cb
Compare
|
I hope the last commit covers all suggestions. Thank you for the review :) |
|
Thanks! Looks great now! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds loop expressions and control flow expressions to Marker's API. With this
cargo dogfoodonly complains about the path resolution of two generic parameters (which I'm planning to fix soon) and closures. The rest seems to be working 🎉.For and While loops again have some interesting desugar, I tried to document them in the code. It seems to be working well, at least according to the test output.
Most of the changes should be test output and documentation as usual. Sorry, that it involves so many changes at once. (I'm totally not using Marker to procrastinate) 😅
r? @Niki4tap If you have the time, I'd appreciate your feedback :)
cc: #52
Not much more to say. For everyone reading this, have a wonderful day :)