-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows installation script #252
Conversation
06db242
to
223e758
Compare
ce74ada
to
121b7fb
Compare
UPD An important caveat is that you'll likely install the latest PowerShell 7.0 on linux, but on real Windows 10/11 the version of powershell is quite old (5.1), so don't try to use any new features. |
6d2cae8
to
f522649
Compare
f522649
to
c0139df
Compare
I'll just leave this here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've tested it on a Windows computer, and it worked perfectly. Thank you for this!
Also, I have to say: I love the comments ^^ It makes reviewing the changes a lot more fun ❤️
Thank you! |
ChatGPT rules.However of course it made a ton of mistakes converting bash to powershell, and I of course I had to stare at powershell syntax with their poor error messages for some time. But, anyway, it's past that and the script works.
You can test it using a separate branch where I configured it to work with my fork.
This was inspired by the installation script in deno. Turns out both
curl.exe
andtar.exe
are available on windows by default, and deno also uses them for its installation script.There are some stupid caveats with using unicode symbols (I'm not even saying ansi colors) on windows. I didn't look into that, and just made the script monochrome and use
>
character for logging the executed commands.I didn't update the docs here. I think I'll just make separate PR for that whicj will also include the commit with the docs for linux
Also fixed the behavior of
install.sh
when the$CARGO_HOME
variable is set. Previously it was writing directly to it, but instead it has to write to a$CARGO_HOME/bin
subdirectory.