Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail when ptrace::detach() returns an ESRCH error #29

Closed
gabrielesvelto opened this issue May 24, 2022 · 0 comments · Fixed by #68
Closed

Don't fail when ptrace::detach() returns an ESRCH error #29

gabrielesvelto opened this issue May 24, 2022 · 0 comments · Fixed by #68

Comments

@gabrielesvelto
Copy link
Contributor

If one of the threads we've suspended disappears while we're writing the minidump the call to ptrace::detach() in PtraceDumper::resume_thread() will fail setting errno to ESRCH. This is a completely benign error which we can ignore since we simply don't care about the state of the process/thread after we're done with it. The same applies to pretty much any other use of pthread::detach(), we could ignore this error for all of them.
afranchuk added a commit to afranchuk/minidump-writer that referenced this issue Jan 5, 2023
@afranchuk
Don't fail when ptrace::detach returns ESRCH.
55392e9 
ESRCH indicates that the thread has disappeared while we had it stopped. We don't consider this an error.

Closes rust-minidump#29.
@afranchuk afranchuk mentioned this issue Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't fail when ptrace::detach returns ESRCH. afranchuk/minidump-writer
1 participant
@gabrielesvelto