Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that the notes holding the GNU build ID have the name set to "GNU" (aka ELF_NOTE_GNU) #73

Closed
gabrielesvelto opened this issue Feb 28, 2023 · 0 comments · Fixed by #74
Closed

Verify that the notes holding the GNU build ID have the name set to "GNU" (aka ELF_NOTE_GNU) #73

gabrielesvelto opened this issue Feb 28, 2023 · 0 comments · Fixed by #74

Comments

@gabrielesvelto
Copy link
Contributor

When looking for the build ID we only verify that the notes are of type NT_GNU_BUILD_ID. There could be notes with that type that aren't GNU notes as unlikely as it may be, so we should also check that the note name is "GNU".
gabrielesvelto added a commit to gabrielesvelto/minidump-writer that referenced this issue Feb 28, 2023
@gabrielesvelto
Check the note names when looking for the GNU build ID on Linux
d9473bf 
This fixes issue rust-minidump#73
gabrielesvelto added a commit to gabrielesvelto/minidump-writer that referenced this issue Feb 28, 2023
@gabrielesvelto
Check the note names when looking for the GNU build ID on Linux
b2515fa 
This fixes issue rust-minidump#73
gabrielesvelto added a commit to gabrielesvelto/minidump-writer that referenced this issue Feb 28, 2023
@gabrielesvelto
Check the note names when looking for the GNU build ID on Linux
c5c9c06 
This fixes issue rust-minidump#73
@Jake-Shadle Jake-Shadle mentioned this issue Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check the note names when looking for the GNU build ID on Linux gabrielesvelto/minidump-writer
1 participant
@gabrielesvelto