Read ELF SONAMEs directly from process memory when possible. #117
Conversation
When this fails, it falls back to the previous behavior of trying to open the mapped file name directly. Closes rust-minidump#79.
afranchuk
force-pushed
the
in-memory-soname
branch
from
cfe5e46 to
e56f764
Compare
|
I'll update the ELF fixture to add an SONAME to test this. |
|
Sorry my review is taking a bit but I'm doing some testing directly in Firefox and this seems to work only for external libraries, not our own ones, so I'm trying to figure out what's wrong (or if it's something specific to my box). |
afranchuk
force-pushed
the
in-memory-soname
branch
from
8938433 to
0c2a2e8
Compare
|
Not all binaries have the section header table present when loaded in memory. However the program headers will be there, so I added another path which is preferred and uses only the program headers and the dynamic section information. This seems to work with all shared objects loaded by firefox at runtime when I tested it. We might still want a fallback of trying to load directly from the file (if present) if reading from memory fails for some reason. |
afranchuk
force-pushed
the
in-memory-soname
branch
from
0c2a2e8 to
cfe6615
Compare
|
I'm not sure why the android test is failing... |
| # By default the linker _doesn't_ generate a build-id, however we want one for our tests. | ||
| rustflags = ["-C", "link-args=-Wl,--build-id=sha1"] |
|
This is probably ready to merge. |
When this fails, it falls back to the previous behavior of trying to open the mapped file name directly.
Closes #79.