Use fixed dimension in error tests

rust-ml · Mar 1, 2024 · 151900a · 151900a
1 parent a5f1ad3
commit 151900a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/algorithms/linfa-reduction/src/error.rs b/algorithms/linfa-reduction/src/error.rs
@@ -24,6 +24,6 @@ pub enum ReductionError {
     InvalidPrecision,
     #[error("Target dimension of the projection must be positive")]
     NonPositiveEmbeddingSize,
-    #[error("Target dimension {0} is larger than the number of features {1}. ")]
+    #[error("Target dimension {0} is larger than the number of features {1}.")]
     DimensionIncrease(usize, usize),
 }
diff --git a/algorithms/linfa-reduction/src/random_projection/mod.rs b/algorithms/linfa-reduction/src/random_projection/mod.rs
@@ -67,7 +67,7 @@ mod tests {
         let records = array![[10., 10.], [1., 12.], [20., 30.], [-20., 30.],];
         let dataset = Dataset::from(records);
         let res = GaussianRandomProjection::<f32>::params()
-            .eps(0.1)
+            .target_dim(10)
             .fit(&dataset);
         assert!(res.is_err())
     }
@@ -76,7 +76,7 @@ mod tests {
         let records = array![[10., 10.], [1., 12.], [20., 30.], [-20., 30.],];
         let dataset = Dataset::from(records);
         let res = SparseRandomProjection::<f32>::params()
-            .eps(0.1)
+            .target_dim(10)
             .fit(&dataset);
         assert!(res.is_err())
     }

diff --git a/algorithms/linfa-reduction/src/random_projection/sparse/algorithms.rs b/algorithms/linfa-reduction/src/random_projection/sparse/algorithms.rs
@@ -119,4 +119,3 @@ impl<F: Float> SparseRandomProjection<F> {
 }
 
 impl_proj! {SparseRandomProjection<F>}
-