Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Linear Regression: Use ndarray-linalg's lstsq, improve names and follow conventions #25

Closed
paulkoerbitz opened this issue Jul 27, 2020 · 0 comments · Fixed by #125
Closed

Improve Linear Regression: Use ndarray-linalg's lstsq, improve names and follow conventions #25

paulkoerbitz opened this issue Jul 27, 2020 · 0 comments · Fixed by #125
Milestone
0.2

Comments

@paulkoerbitz
Copy link
Collaborator

There are some improvements to the linear regression / least squares code which would be nice to implement.

  • Use least squares from ndarray-linalg (lapack), now that it is exposed
  • Address comments from original PR
    • Fix names fit_intercept, fit_intercept_with_normalisation to be consistent with linfa-logistic
  • Follow C-GETTER for getter names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Use least_squares solver from ndarray-linalg
Use least_squares solver from ndarray-linalg
1 participant
@paulkoerbitz