Use least_squares solver from ndarray-linalg #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this PR depends on version 0.13 of Related #110 |
|
any reason why you closed this? I was afk till yesterday because of Easter and there are more pressuring issues right now, but your PR is on my todo list. I would first finish the ndarray update before merging though. |
|
@bytesnake I closed it because I realized that I had handled the ndarray version update very poorly. I thought that it would be cleaner/nicer to submit a new PR after #110 had been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the least squares solver from
ndarray-linalginstead of solving the normal equations explicitly.Note that version 0.13 of
ndarray-linalgis needed so that theLapacktrait includesLeastSquaresSvdDivideConquer_(commit rust-ndarray/ndarray-linalg@3c951ff).Resolves #25