Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute pre-built binaries for cargo-apk #31

Closed
notgull opened this issue Aug 29, 2023 · 3 comments
Closed

Distribute pre-built binaries for cargo-apk #31

notgull opened this issue Aug 29, 2023 · 3 comments

Comments

@notgull
Copy link

notgull commented Aug 29, 2023

At the moment, winit's CI pipeline builds or caches a fresh copy of cargo-apk for Android. It would be cleaner to instead just install the binary through install-action or cargo-binstall.

However, cargo apk does not distribute binaries that can be installed. It would be better if pre-built binaries of cargo-apk were distributed through GitHub Actions, so that they can be easily installed by users.

See here for an example of how this can be done automatically through a release pipeline. I am willing to write the CI code, but I need cooperation from a @rust-mobile admin to handle setting up secret keys.

@MarijnS95
Copy link
Member

cargo-apk has been deprecated some years ago in favour of xbuild, so I don't think I would spend time engineering such a thing. There isn't even enough time to get xbuild on-par with cargo-apk in certain areas.

@notgull
Copy link
Author

notgull commented Aug 29, 2023

cargo-apk has been deprecated some years ago in favour of xbuild,

Hmm, I wasn't aware of this. It should probably be signaled better in this repository, as winit still uses it in CI.

@MarijnS95
Copy link
Member

It looks like it got "lost" (or rather, not a purpose-made one added) when this repo was split out from the main ndk/android-ndk-rs repo.

@MarijnS95 MarijnS95 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants