-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for xbuild #212
Conversation
xbuild is a tool for building iOS/Android apps in Rust. Signed-off-by: John Nunley <dev@notgull.net>
https://github.com/taiki-e/install-action/actions/runs/6014566895/job/16314554693
🤔 |
This is odd. The maintainer for |
Oh wait, that's Mono's It looks like I should install the |
You can add a special case here. Line 72 in cc5a5c5
Probably something like. case "${tool}" in
build) installed_bin="${bin_dir}/x" ;;
*) installed_bin="${bin_dir}/$(basename "${bin_in_archive}")" ;;
esac And here too. Line 576 in cc5a5c5
|
Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
Ugggh, I've opened rust-mobile/xbuild#132 to deal with this. Until then I guess I'll just install |
Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
This reverts commit 27355f5.
Hmm, it looks like |
For now, I think we can adjust https://github.com/taiki-e/install-action/blob/main/tools/ci/tool-list.sh and mark xbuild as glibc_pre_2_34_incompat.
We test a number of environments in CI, but the ones that actually important for most users are the -latest variants of the GitHub-hosted runner: ubuntu-latest (ubuntu-22.04), macos-latest (macos-12), and windows-latest (windows-2022) |
Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
At least in their 0.1.x versions, the release tag does not seem to match the crate version. https://crates.io/crates/xbuild/versions If that has been fixed in 0.2.x and up, that is fine, but otherwise it will be confusing because it will install something that does not match the crate version specified by the user. |
Hmm, yes, that seems problematic. @dvc94ch When you make |
Signed-off-by: John Nunley <dev@notgull.net>
We already have a gh action: https://github.com/rust-mobile/setup-xbuild-action |
Co-authored-by: Taiki Endo <te316e89@gmail.com>
It looks like that uses the GitHub CLI though, which needs a secret token to work. Edit: it looks like there is also no control over the version installed, which is important for some cases. |
@dvc94ch Poke. Given the reasons above I feel that this is a good reason why |
Yeah, really annoying that gh cli requires a token to download a release, I know. xbuild has different components I think the release tag versions the sdk build and has nothing to do with the crate version |
Hmm, so should this crate just ignore versions with |
As xbuild updates with new SDKs unrelated to the underlying release, this commit makes the manifest generator ignore those releases. Signed-off-by: John Nunley <dev@notgull.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Published in 2.18.0. |
xbuild is a tool for building iOS/Android apps in Rust.