ndk: Add tool_type getter for Pointer events
#323
Conversation
| let tool_type = unsafe { | ||
| ffi::AMotionEvent_getToolType(self.event.as_ptr(), self.index as ffi::size_t) as u32 | ||
| }; | ||
| tool_type.try_into().unwrap() |
There was a problem hiding this comment.
It seems that in some cases we use .try_into().unwrap_or(XXX::Unknown), but I'd have to ask @mb64 why that wasn't done in all cases.
Though I think I'd rather panic than consider every yet-unknown value to be equivalent to the literal _UNKNOWN constant, as this typically means the NDK or these enums need an update (which I'd like to mitigate even further by generating these types and derives in bindgen directly, but that hasn't materialized yet and especially the event code uses anonymous enums and typedefs which can't yet be interpreted that way). For example, Source is missing Hdmi and Sensor :)
There was a problem hiding this comment.
Thanks, this looks okay to me!
The CI failure is not your fault, GitHub's Virtual Environments team removed an "erroneous" ndk-bundle symlink but also seems to have deemed it necessary to delete all environment variables with it - instead of pointing them to a different known-working folder 😞 - actions/runner-images#5879.
|
@Atilogit I had to rebase and force-push your branch to make the CI re-run, all failed CI runs seem to be old enough that there's no "rerun [failed] jobs" button anymore. EDIT: Unfortunately your signature is now lost, so you might want to redo that yourself instead :) |
|
Thank you for getting back to this! |
|
It took a while for Github to roll out the fixed images, while I was on holiday. Do you want to add a changelog entry for this? |
|
Sure, if it's not an issue. |
|
@Atilogit Feel free to push one or let me know if I have to add it for you before merging. |
|
On it right now |
MarijnS95
changed the title
tool_type getter for Pointer events
This maintains compatibility with the `ndk` crate's `Pointer` API Ref: rust-mobile/ndk#323 This will also be required for enabling pen pressure support to Winit, re: rust-windowing/winit#2396
This maintains compatibility with the `ndk` crate's `Pointer` API Ref: rust-mobile/ndk#323 This will also be required for enabling pen pressure support to Winit, re: rust-windowing/winit#2396
This maintains compatibility with the `ndk` crate's `Pointer` API Ref: rust-mobile/ndk#323 This will also be required for enabling pen pressure support to Winit, re: rust-windowing/winit#2396
I'm working on a PR for winit that adds stylus support for Windows and Android.
This getter is required to differentiate between touch, mouse and stylus inputs consistently.