Improve clamp implementation

rust-ndarray · Dec 6, 2023 · fa57078 · fa57078
1 parent a982f0b
commit fa57078
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/src/numeric/impl_float_maths.rs b/src/numeric/impl_float_maths.rs
@@ -160,17 +160,9 @@ where
     ///
     /// # Panics
     ///
-    /// Panics if `min > max`, `min` is `NaN`, or `max` is `NaN`.
+    /// Panics if `!(min <= max)`.
     pub fn clamp(&self, min: A, max: A) -> Array<A, D> {
         assert!(min <= max, "min must be less than or equal to max");
-        self.mapv(|v| {
-            if v < min {
-                min.clone()
-            } else if v > max {
-                max.clone()
-            } else {
-                v
-            }
-        })
+        self.mapv(|a| num_traits::clamp(a, min.clone(), max.clone()))
     }
 }