Add in/to_slice_memory_order for ArrayView/Mut #1015
Conversation
jturner314
force-pushed
the
to_slice_memory_order
branch
from
d79c86f
to
6cbac5c
Compare
| @@ -221,6 +253,22 @@ where | |||
| } | |||
| } | |||
|
|
|||
| /// Return the array’s data as a slice, if it is contiguous. | |||
| /// Otherwise return self in the Err branch of the result. | |||
| fn try_into_slice_memory_order(self) -> Result<&'a mut [A], Self> { | |||
There was a problem hiding this comment.
I guess it's even harder to make consistent, but I think this method is unfortunately generally useful. I've contemplated adding the corresponding one on ArrayBase (where the Err case would be &mut Self). So we should consider if this isn't the best one (or an additional one) to expose for ArrayViewMut.
There was a problem hiding this comment.
What if we change all the .as_slice*/.to_slice*/.into_slice* methods return a Result? Even if the Err variant isn't especially useful for all the methods, it'll just be a reference (i.e. pointer size) for all but the .into_slice* methods, so it won't cost much.
bluss
force-pushed
the
to_slice_memory_order
branch
from
6cbac5c
to
551f9c9
Compare
|
Rebased and got the newest spelling from #1119 so we're up to date on that too 😉 |
|
Thanks I'll merge and future improvements can come later - the Result question is left here and it sounds like it could be a good idea! Nice to have the negative tests included here. |
This adds a
.to_slice_memory_order()method toArrayViewand an.into_slice_memory_order()method toArrayViewMut. This has unfortunate code duplication with.as_slice_memory_order/_mut(), but the quantity of duplicated code isn't very large.