Update approx to >=0.4, <0.6 to support approx 0.5 #1024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`approx` 0.5 updates its `num-complex` dependency to 0.4, which is the same version of `num-complex` which `ndarray` depends on. So, it's very useful for `ndarray` to support `approx` 0.5. Instead of expanding the range of the `approx` versions, another option would be to add another feature for `approx` 0.5, but I don't think the additional complexity would be worth it. When we release the next breaking release of `ndarray`, I think we should change this version specification to "0.5".
|
Isn't the effect of this change de facto breaking, too? |
|
Huh, this approach doesn't work well. It seems that if a crate depends on |
|
That's very unfortunate. It seems like the only non-breaking option is to add a separate feature for |
|
The approach in this PR doesn't work. I've created #1025 as a replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
approx0.5 updates itsnum-complexdependency to 0.4, which is the same version ofnum-complexwhichndarraydepends on. So, it's very useful forndarrayto supportapprox0.5. Instead of expanding the range of theapproxversions, another option would be to add a separate feature forapprox0.5, but I don't think the additional complexity would be worth it. When we release the next breaking release ofndarray, I think we should change this version specification to "0.5".