Make CowArray an owned storage array, require Clone bound for into_shared
#1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
force-pushed
the
cowrepr-dataowned
branch
from
36954ef to
de793b3
Compare
|
rebased |
bluss
force-pushed
the
cowrepr-dataowned
branch
from
de793b3 to
9681aba
Compare
bluss
changed the title
A: Clone bound to into_shared and implement DataOwned for CowReprinto_shared
bluss
changed the title
into_sharedCowArray an owned storage array, require Clone bound for into_shared
bluss
approved these changes
Aug 2, 2024
|
Thanks for this. Accepting without new tests 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
A: Clonebound tointo_sharedand implementDataOwnedforCowReprSee #1027 regarding the
A: Clonebound forinto_shared.I've marked this PR as a draft because it would be good to add some tests using
CowArrayfor methods with aS: DataOwnedbound.