Remove doc(hidden) attr from items in trait impls #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These attributes produce warnings like the following on nightly:
```
warning: `#[doc(hidden)]` is ignored on trait impl items
--> src/indexes.rs:212:5
|
212 | #[doc(hidden)]
| ^^^^^^^^^^^^^^ help: remove this attribute
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: whether the impl item is `doc(hidden)` or not entirely depends on the corresponding trait item
```
I verified that these attributes have no effect on stable (1.60.0) or
nightly (2022-05-16), so they can be safely removed.
jturner314
force-pushed
the
rm-doc-hidden-on-trait-impls
branch
from
0d3da0a
to
bb7cba6
Compare
jturner314
added a commit
to jturner314/ndarray
that referenced
this pull request
Jul 30, 2022
These attributes produce warnings like the following on nightly:
```
warning: `#[doc(hidden)]` is ignored on trait impl items
--> src/indexes.rs:212:5
|
212 | #[doc(hidden)]
| ^^^^^^^^^^^^^^ help: remove this attribute
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: whether the impl item is `doc(hidden)` or not entirely depends on the corresponding trait item
```
I verified that these attributes have no effect on stable (1.60.0) or
nightly (2022-05-16), so they can be safely removed.
jturner314
added a commit
to jturner314/ndarray
that referenced
this pull request
Jul 30, 2022
These attributes produce warnings like the following on nightly:
```
warning: `#[doc(hidden)]` is ignored on trait impl items
--> src/indexes.rs:212:5
|
212 | #[doc(hidden)]
| ^^^^^^^^^^^^^^ help: remove this attribute
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: whether the impl item is `doc(hidden)` or not entirely depends on the corresponding trait item
```
I verified that these attributes have no effect on stable (1.60.0) or
nightly (2022-05-16), so they can be safely removed.
jturner314
added a commit
that referenced
this pull request
Jul 30, 2022
These attributes produce warnings like the following on nightly:
```
warning: `#[doc(hidden)]` is ignored on trait impl items
--> src/indexes.rs:212:5
|
212 | #[doc(hidden)]
| ^^^^^^^^^^^^^^ help: remove this attribute
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: whether the impl item is `doc(hidden)` or not entirely depends on the corresponding trait item
```
I verified that these attributes have no effect on stable (1.60.0) or
nightly (2022-05-16), so they can be safely removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These attributes produce warnings like the following on nightly:
I verified that these attributes have no effect on stable (1.60.0) or nightly (2022-05-16), so they can be safely removed.