Fix contig check for single element arrays #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
force-pushed
the
contig-for-single-element
branch
from
96c74e6 to
c4b0e7a
Compare
bluss
force-pushed
the
contig-for-single-element
branch
2 times, most recently
from
9f4cee3 to
c033453
Compare
Co-authored-by: Adam Reichold <adamreichold@users.noreply.github.com>
When an array has 0 or 1 elements, strides don't matter anymore. The general case of this function handled this correctly, but the special case for ndim == 1 did not.
bluss
force-pushed
the
contig-for-single-element
branch
from
3abf961 to
b02ae59
Compare
bluss
commented
Feb 26, 2024
|
|
||
| let arr2 = array![[1, 2, 3], [4, 5, 6]]; | ||
| assert_matches!(arr2.slice(s![.., 2..3]).as_slice_memory_order(), None); | ||
| assert_matches!(arr2.slice(s![1, 2..3]).as_slice_memory_order(), Some(&[6])); |
There was a problem hiding this comment.
The 2D case was working correctly before this fix too.
adamreichold
approved these changes
Feb 26, 2024
|
thanks for checking. The lint fixes are helpful here too, best to get them in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an array has 0 or 1 elements, strides don't matter anymore. The general case of this function handled this correctly, but the special case for ndim == 1 did not.
Fixes #1359