Fix infinite recursion and off-by-one error in triu/tril #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
reviewed
Aug 7, 2024
bluss
reviewed
Aug 7, 2024
src/tri.rs
Outdated
|
|
||
| res | ||
| } | ||
| if is_layout_f(&self.dim, &self.strides) && !is_layout_c(&self.dim, &self.strides) { |
There was a problem hiding this comment.
Thanks for the work on this.
Why is there a conditional on memory layout? This purely a performance optimization right? Great place to have a comment to say what it's doing.
There was a problem hiding this comment.
Yes it is - I've added a comment detailing the purpose and the point of the two other && conditions.
bluss
reviewed
Aug 7, 2024
bluss
reviewed
Aug 7, 2024
bluss
reviewed
Aug 7, 2024
bluss
changed the title
bluss
reviewed
Aug 8, 2024
bluss
changed the title
bluss
approved these changes
Aug 8, 2024
|
Give me one minute to rebase so my commits are signed (switched computers and forgot to turn signing on) and then you can go ahead and squash merge. |
|
I'm not sure why it said it was out of sync with master, maybe because of ci.yaml changes in master. Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes the documentation a little nicer to read, since these are such visual methods.
Closes #1415