Fix trait bound on arr1 (op) &arr2 #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
arr1 (op) &arr2
mutatesarr1
for efficiency, but this caused surprising behavior ifarr1
wasArrayViewMut
. This commit requires thatarr
own its data to avoid surprising side effects.This is an example of the old behavior that was surprising:
Note that while this is a breaking change, the stricter trait bound is actually the correct bound according to the documentation.