Fix axis iterators #669
Merged
Fix axis iterators #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the behavior of `.split_at()` and the `NdProducer` implementations for partially-consumed `AxisIter` or `AxisIterMut` instances.
Now, chunk size of zero and axis length of zero are handled correctly.
|
Thanks for reviewing this @bluss! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #639, I came across some bugs in the existing implementations of
AxisIter/MutandAxisChunksIter/Mut. Specifically,The
.split_at()andNdProducerimplementations ofAxisIterCoredidn't handle partially consumed iterators properly.AxisChunksIterandAxisChunksIterMutdidn't properly handle the chunk size being zero or the axis length being zero.I've fixed the bugs and added tests. (Most of the tests fail before this PR, but they all pass after this PR.)