Fix Zip::indexed for the 0-dimensional case #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a panic for 0-dimensional, indexed `Zip` instances which results from an out-of-bounds index in a call to `IndexPtr::stride_offset` in `Zip::inner`. Basically, the "stride" for `IndexPtr` is the axis to update, but for the 0-dimensional case, there are no axes, so `IndexPtr::stride_offset` cannot be called without panicking due to the `self.index[stride]` access. The chosen solution is to add a special check to `Zip::apply_core` for the 0-dimensional case. Another possible solution would be to modify the loop of `Zip::inner` such that an offset would not be performed for an index of zero.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a panic for 0-dimensional, indexed
Zipinstanceswhich results from an out-of-bounds index in a call to
IndexPtr::stride_offsetinZip::inner. Basically, the "stride" forIndexPtris the axis to update, but for the 0-dimensional case,there are no axes, so
IndexPtr::stride_offsetcannot be calledwithout panicking due to the
self.index[stride]access.The chosen solution is to add a special check to
Zip::apply_coreforthe 0-dimensional case. Another possible solution would be to modify
the loop of
Zip::innersuch that an offset would not be performedfor an index of zero.