Scalar + &array and &array + scalar performance improvements #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The new implementation avoids cloning the elements twice, and it avoids iterating over the elements twice. (The old implementation called `.to_owned()` followed by the arithmetic operation, while the new implementation clones the elements and performs the arithmetic operation in the same iteration.) On my machine, this change improves the performance for both contiguous and discontiguous arrays. (`scalar_add_1/2` go from ~530 ns/iter to ~380 ns/iter, and `scalar_add_strided_1/2` go from ~1540 ns/iter to ~1420 ns/iter.) (Other changes to impl applicability removed from this commit.) Co-authored-by: bluss <bluss@users.noreply.github.com>
bluss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the benchmark and performance improvements from #782 by @jturner314, without
the applicable types changes (since they run into some rustc bugs at the moment). Jim Turner is
the author of this, I've only edited the commits to the changes we can integrate now.
@jturner314 writes:
avoids iterating over the elements twice. (The old implementation
called
.to_owned()followed by the arithmetic operation, while thenew implementation clones the elements and performs the arithmetic
operation in the same iteration.)
On my machine, this change improves the performance for both
contiguous and discontiguous arrays. (
scalar_add_1/2go from ~530ns/iter to ~380 ns/iter, and
scalar_add_strided_1/2go from ~1540ns/iter to ~1420 ns/iter.)