Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_u32_digits to both BigInt and BigUint #104

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Add to_u32_digits to both BigInt and BigUint #104

merged 1 commit into from
Sep 23, 2019

Conversation

Speedy37
Copy link
Contributor

This add access to the u32 internal representation but because it returns a Vec of u32, doesn't force you to commit to this internal representation.

cuviper
cuviper reviewed Aug 31, 2019
View reviewed changes
Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding a compromise that doesn't commit to internals.

src/biguint.rs Outdated Show resolved Hide resolved
src/biguint.rs Outdated Show resolved Hide resolved
src/bigint.rs Outdated Show resolved Hide resolved
src/bigint.rs Outdated Show resolved Hide resolved
@cuviper
Copy link
Member

cuviper commented Sep 23, 2019

Thanks!

bors r+

bors bot added a commit that referenced this pull request Sep 23, 2019
@bors @Speedy37
Merge #104
8d398ea 
104: Add to_u32_digits to both BigInt and BigUint r=cuviper a=Speedy37

This add access to the u32 internal representation but because it returns a Vec of u32, doesn't force you to commit to this internal representation.

Co-authored-by: Vincent Rouillé <vincent@speedy37.fr>
@bors
Copy link
Contributor

bors bot commented Sep 23, 2019

Build succeeded

@bors bors bot merged commit a34b878 into rust-num:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Speedy37 @cuviper