Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add divide-by-zero panic messages #144

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Add divide-by-zero panic messages #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/algorithms.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ pub(crate) fn scalar_mul(a: &mut [BigDigit], b: BigDigit) -> BigDigit {

pub(crate) fn div_rem(mut u: BigUint, mut d: BigUint) -> (BigUint, BigUint) {
if d.is_zero() {
panic!()
panic!("attempt to divide by zero")
}
if u.is_zero() {
return (Zero::zero(), Zero::zero());
Expand Down Expand Up @@ -597,7 +597,7 @@ pub(crate) fn div_rem(mut u: BigUint, mut d: BigUint) -> (BigUint, BigUint) {

pub(crate) fn div_rem_ref(u: &BigUint, d: &BigUint) -> (BigUint, BigUint) {
if d.is_zero() {
panic!()
panic!("attempt to divide by zero")
}
if u.is_zero() {
return (Zero::zero(), Zero::zero());
Expand Down
5 changes: 4 additions & 1 deletion src/bigint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3250,7 +3250,10 @@ impl BigInt {
!exponent.is_negative(),
"negative exponentiation is not supported!"
);
assert!(!modulus.is_zero(), "divide by zero!");
assert!(
!modulus.is_zero(),
"attempt to calculate with zero modulus!"
);

let result = self.data.modpow(&exponent.data, &modulus.data);
if result.is_zero() {
Expand Down
22 changes: 14 additions & 8 deletions src/biguint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,7 @@ impl Div<BigUint> for u32 {
#[inline]
fn div(self, other: BigUint) -> BigUint {
match other.data.len() {
0 => panic!(),
0 => panic!("attempt to divide by zero"),
1 => From::from(self as BigDigit / other.data[0]),
_ => Zero::zero(),
}
Expand Down Expand Up @@ -1280,7 +1280,7 @@ impl Div<BigUint> for u64 {
#[inline]
fn div(self, other: BigUint) -> BigUint {
match other.data.len() {
0 => panic!(),
0 => panic!("attempt to divide by zero"),
1 => From::from(self / u64::from(other.data[0])),
2 => From::from(self / big_digit::to_doublebigdigit(other.data[1], other.data[0])),
_ => Zero::zero(),
Expand All @@ -1291,7 +1291,7 @@ impl Div<BigUint> for u64 {
#[inline]
fn div(self, other: BigUint) -> BigUint {
match other.data.len() {
0 => panic!(),
0 => panic!("attempt to divide by zero"),
1 => From::from(self / other.data[0]),
_ => Zero::zero(),
}
Expand Down Expand Up @@ -1322,7 +1322,7 @@ impl Div<BigUint> for u128 {
#[inline]
fn div(self, other: BigUint) -> BigUint {
match other.data.len() {
0 => panic!(),
0 => panic!("attempt to divide by zero"),
1 => From::from(self / u128::from(other.data[0])),
2 => From::from(
self / u128::from(big_digit::to_doublebigdigit(other.data[1], other.data[0])),
Expand All @@ -1339,7 +1339,7 @@ impl Div<BigUint> for u128 {
#[inline]
fn div(self, other: BigUint) -> BigUint {
match other.data.len() {
0 => panic!(),
0 => panic!("attempt to divide by zero"),
1 => From::from(self / other.data[0] as u128),
2 => From::from(self / big_digit::to_doublebigdigit(other.data[1], other.data[0])),
_ => Zero::zero(),
Expand Down Expand Up @@ -1424,7 +1424,7 @@ macro_rules! impl_rem_assign_scalar {
fn rem_assign(&mut self, other: &BigUint) {
*self = match other.$to_scalar() {
None => *self,
Some(0) => panic!(),
Some(0) => panic!("attempt to divide by zero"),
Some(v) => *self % v
};
}
Expand Down Expand Up @@ -2686,7 +2686,10 @@ impl BigUint {
///
/// Panics if the modulus is zero.
pub fn modpow(&self, exponent: &Self, modulus: &Self) -> Self {
assert!(!modulus.is_zero(), "divide by zero!");
assert!(
!modulus.is_zero(),
"attempt to calculate with zero modulus!"
);

if modulus.is_odd() {
// For an odd modulus, we can use Montgomery multiplication in base 2^32.
Expand Down Expand Up @@ -2725,7 +2728,10 @@ impl BigUint {
}

fn plain_modpow(base: &BigUint, exp_data: &[BigDigit], modulus: &BigUint) -> BigUint {
assert!(!modulus.is_zero(), "divide by zero!");
assert!(
!modulus.is_zero(),
"attempt to calculate with zero modulus!"
);

let i = match exp_data.iter().position(|&r| r != 0) {
None => return BigUint::one(),
Expand Down