Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invmod algorithm #182

Closed
wants to merge 1 commit into from
Closed

Add invmod algorithm #182

wants to merge 1 commit into from

Conversation

unseddd
Copy link

@unseddd unseddd commented Dec 22, 2020

Add invmod algorithm using Extended Euclidean Algorithm

Based on implementation from wolfSSL (fp_invmod directly below fp_invmod_slow)

Add invmod algorithm using Extended Euclidean Algorithm

Based on implementation from wolfSSL
@cuviper
Copy link
Member

cuviper commented Dec 22, 2020

I'm sorry, but I can't accept code that was translated from GPL-licensed code:
https://www.gnu.org/licenses/gpl-faq.html#TranslateCode

There's a generic implementation in rust-num/num-integer#10, and assuming we move that to a trait (on Integer or something new) then we can optimize it further here for num-bigint. (But that still must be clean from incompatibly-licensed code!)

@cuviper cuviper closed this Dec 22, 2020
@unseddd
Copy link
Author

unseddd commented Dec 22, 2020

I'm sorry, but I can't accept code that was translated from GPL-licensed code

No worries, I wasn't aware this library is not compatible with GPL. I was using similar code in another project, so figured I would try porting it upstream.

Just trying to help out.

There's a generic implementation in rust-num/num-integer#10

Cool! Hope it gets implemented for Big(U)Int, really helpful for crypto stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants