Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AsPrimitive Safety docs for rust 1.45 #184

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

martin-t
Copy link
Contributor

Fixes #174

The safety section should not be removed entirely since people might be using older compilers (as was pointed out to me in a related issue in the vek crate).

However, this and followup comments indicate that the second case (float to float) was never UB in the first place - should the second example be removed?

@cuviper
Copy link
Member

cuviper commented Aug 18, 2020

Hi,

However, this and followup comments indicate that the second case (float to float) was never UB in the first place - should the second example be removed?

Yes, I think we can remove that altogether -- would you like to do that here?

@martin-t
Copy link
Contributor Author

Sure, I also changed the phrasing into past tense in the first example and removed the bullet point since it's no longer a list. Is is ok like this?

@cuviper
Copy link
Member

cuviper commented Aug 24, 2020

Works for me, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 24, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning in docs of num_traits::cast::AsPrimitive seems to be out-of-date
2 participants