-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bounds.rs
#248
base: master
Are you sure you want to change the base?
Improve bounds.rs
#248
Conversation
→ Trait now contains associated constants rather than non-`const` functions. → `LowerBounded` and `UpperBounded` are now supertraits of `Bounded`, not subtraits. 2) Expanded implementations to also cover `NonZero` data-types. 3) Made the code DRYer, with regards to the implementation of `bounded_impl!`. 4) Added a couple tests.
To clarify, as the code is currently written all tests pass. But I think something's amiss. I just tried a toy program that used the new The closest I've come to making some semblance of sense out of this is that, apparently, there are several macros in the test suite (eg I ultimately managed to get it to work by 1) adding |
Agreed so far...
This is bizarre. I would not expect Even in the same file, test |
I want this so bad. |
→ Trait now contains associated constants rather than non-
const
functions.→
LowerBounded
andUpperBounded
are now supertraits ofBounded
, not subtraits.NonZero
data-types.bounded_impl!
.