Make float::Float::integer_decode DRY
#328
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`float::Float::integer_decode`
mtilda
force-pushed
the
mtilda/enhance/float-integer-decode
branch
from
141f91e
to
6d30ca6
Compare
mtilda
changed the title
integer_decode_f32 and integer_decode_f64 with new macro integer_decode!float::Float::integer_decode DRY
… new macro `integer_decode\!`
mtilda
force-pushed
the
mtilda/enhance/float-integer-decode
branch
from
3971e1c
to
0a0a8e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #327
Motivation
The trait method
float::Float::integer_decodeinvokes one of the functionsinteger_decode_f32orinteger_decode_f64depending on the implementation. These functions share a lot of code, so I would like to refactor them to use the same underlying source.Considerations
float::Float::integer_decode#327.Status
This is a work in progress, as indicated by the fact that it is a Draft PR. Comments and suggestions are welcome, but not expected.