Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: serde 1.0 #305

Merged
merged 5 commits into from
Jun 22, 2017
Merged

WIP: serde 1.0 #305

merged 5 commits into from
Jun 22, 2017

Conversation

rubdos
Copy link

@rubdos rubdos commented Jun 20, 2017

W.r.t. #302 & #218, I took the arrow to the knee and started changing what needed changing.

TODO: Done; that was quicker than I thought.

  • BigInt
  • Complex
  • Rational

Did I miss more serde stuff?

@rubdos rubdos force-pushed the serde1 branch 2 times, most recently from 0198a07 to c5deb21 Compare June 20, 2017 18:32
@oli-obk
Copy link

oli-obk commented Jun 21, 2017

Travis still has a cargo update -p serde --precise 0.7.0 which probably needs to be updated ;)

@rubdos
Copy link
Author

rubdos commented Jun 21, 2017

Travis still has a cargo update -p serde --precise 0.7.0 which probably needs to be updated ;)

Did I miss something else? :-)

@oli-obk
Copy link

oli-obk commented Jun 21, 2017

Rust 1.8 isn't supported anymore. Serde needs 0.13 I think (at least that's what our travis checks)

@rubdos
Copy link
Author

rubdos commented Jun 21, 2017

Rust 1.8 isn't supported anymore. Serde needs 0.13 I think (at least that's what our travis checks)

So remove that too? I'll put in 1.13

EDIT2: I'm on Gitter if you want, on #rust-num/num according to weechat.

@rubdos
Copy link
Author

rubdos commented Jun 21, 2017

Seems like I had forgot a file.

@rubdos
Copy link
Author

rubdos commented Jun 21, 2017

Seem to pass now. Is there a reason though, to still support 1.13?

@cuviper
Copy link
Member

cuviper commented Jun 21, 2017 via email

@@ -29,7 +29,7 @@ version = "0.3.19"

[dependencies.serde]
optional = true
version = ">= 0.7.0, < 0.9.0"
version = ">= 1.0.0, < 2.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this a simple "1.0" dependency.

@rubdos rubdos force-pushed the serde1 branch 3 times, most recently from 9d3f49f to e079033 Compare June 21, 2017 09:19
@cuviper cuviper merged commit 3c024f2 into rust-num:next Jun 22, 2017
@cuviper
Copy link
Member

cuviper commented Jun 22, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants