-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: serde 1.0 #305
WIP: serde 1.0 #305
Conversation
0198a07
to
c5deb21
Compare
Travis still has a |
Did I miss something else? :-) |
Rust 1.8 isn't supported anymore. Serde needs 0.13 I think (at least that's what our travis checks) |
EDIT2: I'm on Gitter if you want, on #rust-num/num according to weechat. |
Seems like I had forgot a file. |
Seem to pass now. Is there a reason though, to still support 1.13? |
I consider it a breaking change to bump the minimum rust, so please don't
remove 1.8 testing entirely here. Just add 1.13 to CI as the minimum for
using serde.
(Even though we *are* making a breaking change here, let's isolate that
change to serde for the moment.)
|
bigint/Cargo.toml
Outdated
@@ -29,7 +29,7 @@ version = "0.3.19" | |||
|
|||
[dependencies.serde] | |||
optional = true | |||
version = ">= 0.7.0, < 0.9.0" | |||
version = ">= 1.0.0, < 2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this a simple "1.0" dependency.
9d3f49f
to
e079033
Compare
Thanks! |
W.r.t. #302 & #218, I took the arrow to the knee and started changing what needed changing.
TODO:Done; that was quicker than I thought.Did I miss more
serde
stuff?