add clarabel wasm feature flag

[Specy]

Adds the possibility to specify wasm feature flag to clarabel

[lovasoa]

See this previous comment on the same topic: #58 (comment)

If you need this just for yourself, see: https://stackoverflow.com/questions/59994525/how-do-i-specify-features-for-a-sub-dependency-in-cargo

[Specy]

If you need this just for yourself, see: https://stackoverflow.com/questions/59994525/how-do-i-specify-features-for-a-sub-dependency-in-cargo

I've tried setting:

good_lp = { version = "1.8.1", features = ['clarabel'], default-features = false }
clarabel = { version = "*", features = ['wasm']} #also tried to put version as 0.9.0

but this does not seem to enable the feature flag.

Looking at the SO comment, it seems like this was disabled in rust 1.80?

What kind of test for CI were you thinking? simple build under wasm32-unknown-unknown?

[lovasoa]

Ideally we would run wasm tests too

[Specy]

i'm gonna also include minilp to the WASM tests

[lovasoa]

This looks good !

Can we mention the new feature in the readme, maybe in the clarabel section ?

Then we can merge this !

[Specy]

I have absolutely no idea what that error is! Probably some mismatch in versions, I'll check later when I'm back home.

Should I add a new column in the table for things that support wasn't or add it as a new section note?

[lovasoa]

I opened an issue on the clarabel side: oxfordcontrol/Clarabel.rs#134

It looks like the "wasm" feature should be removed. Clarabel could just compile for wasm natively if dependencies and conditional compilation were set up properly on their side: oxfordcontrol/Clarabel.rs#134

This does not prevent us to merge this pr on our side, to prevent future changes that would break wasm compatibility in good_lp itself.

[Specy]

It looks like the "wasm" feature should be removed. Clarabel could just compile for wasm natively if dependencies and conditional compilation were set up properly on their side: oxfordcontrol/Clarabel.rs#134

I'll try to make a PR there too to fix it

I'll also add wasm support as a new column to the table to show which solvers are able to be compiled to wasm. If in the future it will be able to compile to wasm-unknown-emscripten in wasm-pack I could also include soplex so this seems like a flexible solution. What do you think?

[Specy]

Ok the CI should be fixed now, just had to install node.

The clarabel repository seems a bit inactive so i'd say to merge this for now until the issue is fixed in clarabel

[lovasoa]

Thank you for your contribution, @Specy !