Rewrite for new bootloader build system #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
force-pushed
the
next-version
branch
5 times, most recently
from
26de19a to
004f06c
Compare
A timeout greater than 2^32 seconds (~136 years) does not make much sense, so we can use u32 instead of u64.
phil-opp
force-pushed
the
next-version
branch
4 times, most recently
from
f51e1ca to
34c1f47
Compare
This is the same behavior as `bootimage run`.
This functionality is better implemented manually on top of `bootimage run`. Such a manual implementation can be a proper workspace member and correctly share the sysroot and the target artifacts (with the `bootimage tester` we don't achieve sharing because the dependency fingerprints differ).
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 2, 2019
34: Rewrite for new bootloader build system r=phil-opp a=phil-opp This PR rewrites the `bootimage` crate to work with the new bootloader build system proposed in rust-osdev/bootloader#51. It also removes support for some old configuration options and for the `bootloader_precompiled` crate. See the changelog updates for more information. Note that this new version will only work with bootloader `0.5.0` or later. Todo: - [x] Add a `cargo-bootimage` executable - [x] Create a `bootimage runner` subcommand - [x] Create a `bootimage tester` subcommand - [x] Blocked on rust-osdev/bootloader#51 - [x] Rustdoc - [x] Mention new runner ~/tester~ in the Readme - [x] Command line help for new commands - [x] Error message for older bootloader versions (with old build system) - [x] Update changelog Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Build succeeded
|
|
Published as version 0.7.0-beta.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the
bootimagecrate to work with the new bootloader build system proposed in rust-osdev/bootloader#51. It also removes support for some old configuration options and for thebootloader_precompiledcrate. See the changelog updates for more information.Note that this new version will only work with bootloader
0.5.0or later.Todo:
cargo-bootimageexecutablebootimage runnersubcommand/testerin the Readme