Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 3dnow features from stage4 target #471

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Remove 3dnow features from stage4 target #471

merged 1 commit into from
Nov 1, 2024

Conversation

Ollrogge
Copy link
Contributor

@Ollrogge Ollrogge commented Nov 1, 2024

Remove the 3dnow features from the stage4 target since rust removed support for them.

This silences the following messages while building:

'-3dnow' is not a recognized feature for this target (ignoring feature)
'-3dnowa' is not a recognized feature for this target (ignoring feature)

Freax13
Freax13 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Looks good to me! :shipit:

@Freax13 Freax13 enabled auto-merge November 1, 2024 12:35
@Freax13 Freax13 merged commit 0188e71 into rust-osdev:main Nov 1, 2024
9 checks passed
@Freax13 Freax13 mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freax13 Freax13 Freax13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ollrogge @Freax13