Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guide on chainloading #66

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Add guide on chainloading #66

merged 2 commits into from
Jul 15, 2019

Conversation

64
Copy link
Contributor

@64 64 commented Jul 10, 2019

No description provided.

@64
Copy link
Contributor Author

64 commented Jul 10, 2019

Fixes #49

phil-opp
phil-opp approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good to me overall.

README.md Outdated Show resolved Hide resolved
doc/chainloading.md Outdated Show resolved Hide resolved
@phil-opp phil-opp mentioned this pull request Jul 11, 2019
Open
2 tasks
@64
Copy link
Contributor Author

64 commented Jul 11, 2019

CI failures seem unrelated

@phil-opp
Copy link
Member

Thanks for the updates!

Yes, the CI failures were because of rust-lang/rust#62562. This should be fixed in the latest nightly.

bors r+

bors bot added a commit that referenced this pull request Jul 15, 2019
@bors @64
Merge #66
369821f 
66: Add guide on chainloading r=phil-opp a=64



Co-authored-by: Matt Taylor <mstaveleytaylor@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 15, 2019

Build succeeded

  • rust-osdev.bootloader

@bors bors bot merged commit 8371044 into rust-osdev:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@64 @phil-opp