Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable manipulation of InterruptStackFrame #312

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

haraldh
Copy link
Contributor

@haraldh haraldh commented Oct 14, 2021

Derive Copy for InterruptStackFrameValue or otherwise

error[E0277]: the trait bound `InterruptStackFrameValue: core::marker::Copy` is not satisfied

Signed-off-by: Harald Hoyer harald@profian.com

Derive `Copy` for `InterruptStackFrameValue` or otherwise
```
error[E0277]: the trait bound `InterruptStackFrameValue: core::marker::Copy` is not satisfied
```

Signed-off-by: Harald Hoyer <harald@profian.com>
Copy link
Contributor

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, especially implementing it for InterruptStackFrameValue instead of InterruptStackFrame itself. So users can only do this if they are intentionally manipulating the interrupt frame.

@josephlr josephlr merged commit 6461745 into rust-osdev:master Oct 15, 2021
@haraldh haraldh deleted the isr_frame branch October 15, 2021 08:40
haraldh added a commit to haraldh/enarx that referenced this pull request Oct 15, 2021
Remove unused code from the `idt` copypasta and reduce it to the
absolute minimum.

As soon as `x86_64` > 0.14.6 is released, `InterruptStackFrame`
and `InterruptStackFrameValue` can be removed also, see
rust-osdev/x86_64#312

Signed-off-by: Harald Hoyer <harald@profian.com>
haraldh added a commit to haraldh/enarx that referenced this pull request Oct 15, 2021
Remove unused code from the `idt` copypasta and reduce it to the
absolute minimum.

As soon as `x86_64` > 0.14.6 is released, `InterruptStackFrame`
and `InterruptStackFrameValue` can be removed also, see
rust-osdev/x86_64#312

Signed-off-by: Harald Hoyer <harald@profian.com>
npmccallum pushed a commit to haraldh/enarx that referenced this pull request Oct 18, 2021
Remove unused code from the `idt` copypasta and reduce it to the
absolute minimum.

As soon as `x86_64` > 0.14.6 is released, `InterruptStackFrame`
and `InterruptStackFrameValue` can be removed also, see
rust-osdev/x86_64#312

Signed-off-by: Harald Hoyer <harald@profian.com>
npmccallum pushed a commit to enarx/enarx that referenced this pull request Oct 18, 2021
Remove unused code from the `idt` copypasta and reduce it to the
absolute minimum.

As soon as `x86_64` > 0.14.6 is released, `InterruptStackFrame`
and `InterruptStackFrameValue` can be removed also, see
rust-osdev/x86_64#312

Signed-off-by: Harald Hoyer <harald@profian.com>
@phil-opp phil-opp mentioned this pull request Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants