add workaround for recursive page tables with recursive index 511 #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
reviewed
Jun 15, 2023
src/structures/paging/page_table.rs
Outdated
| // that address sound, but it avoids some easy to trigger | ||
| // miscompilations. | ||
| let ptr = self.entries.as_ptr(); | ||
| (0..512).map(move |i| unsafe { &*ptr.add(i) }) |
There was a problem hiding this comment.
Have you tried whether self.entries[i] works? This way we might be able to avoid the unsafe..
There was a problem hiding this comment.
This should work for iter, but not iter_mut.
phil-opp
approved these changes
Jun 19, 2023
Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds changes the iterator returned by
PageTable::iter{_mut}to a custom iterator that avoids calculating the end pointer of the page table. It also adds a warning against using recursive index 511.Closes #424