Fix data layout in custom target used for testing #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Looks good to me, thanks!
Out of curiosity, do you happen to know why the "p270:32:32..." specs are necessary? If my understanding of https://llvm.org/docs/LangRef.html#data-layout is correct, they specify 32-bit address spaces, and it's not immediately obvious to me what that's useful for.
|
I don't know why/if this part is necessary, but the Rust compiler enforces since rust-lang/rust#120062 that the data-layout matches the layout of the LLVM target exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the test errors on CI.