Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update() to Cr3, Dr7, SFMask, UCet, SCet, mxcsr, rflags, and XCr0 #527

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Dec 24, 2024

This adds update(), akin to update() on Cr0, Cr4, and Efer to the following types/modules:

  • Cr3
  • Dr7
  • SFMask
  • UCet
  • SCet
  • mxcsr
  • rflags
  • XCr0

Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Looks good to me! 🎄

I only needed update() on XCr0 myself, but we could also add update() to Cr3, Dr7, SFMask, UCet, SCet, and rflags, if you think that made sense.

That sounds reasonable to me. Do you want to add these proposed changes to this PR or should we leave this for a later PR?

@mkroening
Copy link
Member Author

Do you want to add these proposed changes to this PR or should we leave this for a later PR?

I can add them to this PR. 👍

@mkroening mkroening changed the title feat(xcontrol): add XCr0::update() feat: add update() to Cr3, Dr7, SFMask, UCet, SCet, mxcsr, rflags, and XCr0 Dec 24, 2024
@mkroening
Copy link
Member Author

All done! :)

Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 🎄 :shipit:

@Freax13 Freax13 merged commit 59ac07c into rust-osdev:master Dec 24, 2024
11 of 13 checks passed
@mkroening mkroening deleted the xcr0-update branch December 24, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants