Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raw-cpuid dependency and use rdrand intrinsics #85

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

64
Copy link
Contributor

@64 64 commented Jul 18, 2019

This reduces my compile times from scratch from about 215s to 160s.

@phil-opp
Copy link
Member

I think the test timeouts are caused by the llvm upgrade of Rust. Somehow older versions of the bootloader error with "page already mapped" when trying to run the test binaries (but interestingly not when running the normal kernel binary). I'll push an update that updates the bootloader version, this should fix the CI failure.

@phil-opp
Copy link
Member

Test update in #86

Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

bors r+

bors bot added a commit that referenced this pull request Jul 19, 2019
85: Remove raw-cpuid dependency and use rdrand intrinsics r=phil-opp a=64

This reduces my compile times from scratch from about 215s to 160s.

86: Update integration tests to use new testing framework r=phil-opp a=phil-opp

Use `cargo xtest` and `bootimage runner` instead of the old `bootimage test` for testing. See https://os.phil-opp.com/testing/ for more information on the approach.

Co-authored-by: Matt Taylor <mstaveleytaylor@gmail.com>
Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors
Copy link
Contributor

bors bot commented Jul 19, 2019

Build succeeded

  • rust-osdev.x86_64

@bors bors bot merged commit d21458f into rust-osdev:master Jul 19, 2019
phil-opp added a commit that referenced this pull request Jul 19, 2019
@phil-opp
Copy link
Member

Published as version 0.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants