Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __m64 support #1050

Closed
vks opened this issue Sep 25, 2020 · 2 comments
Closed

Remove __m64 support #1050

vks opened this issue Sep 25, 2020 · 2 comments

Comments

@vks
Copy link
Collaborator

vks commented Sep 25, 2020

All MMX intrinsics were removed from Rust: rust-lang/stdarch#823

This currently causes packed_simd to not compile (see for instance #1047). Here is the PR that fixes packed_simd: rust-lang/packed_simd#292
Once the new version of packed_simd is released, we will have to remove support for __m64 to make the tests pass.

@vks
Copy link
Collaborator Author

vks commented Sep 28, 2020

Also see rust-lang/packed_simd#298.

@vks
Copy link
Collaborator Author

vks commented Sep 30, 2020

This patch uses the fixed packed_simd version:

diff --git a/Cargo.toml b/Cargo.toml
index 40ea48204e..9284f3084f 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -61,8 +61,8 @@ serde = { version = "1.0.103", features = ["derive"], optional = true }

 [dependencies.packed_simd]
 # NOTE: so far no version works reliably due to dependence on unstable features
-version = "0.3"
-# git = "https://github.com/rust-lang-nursery/packed_simd"
+package = "packed_simd_2"
+version = "0.3.4"
 optional = true
 features = ["into_bits"]

However, we still need to fix the following line:

   --> src/distributions/utils.rs:190:35
    |
190 |     wmul_impl_16! { u16x4, __m64, _mm_mulhi_pu16, _mm_mullo_pi16 }

__m64, _mm_mulhi_pu16, and _mm_mullo_pi16 no longer exist and were replaced.

vks added a commit to vks/rand that referenced this issue Oct 8, 2020
This is necessary, because support for `__m64` was removed from nighly
Rust [1].

Fixes rust-random#1050.

[1] rust-lang/stdarch#823
@vks vks closed this as completed in fe34550 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant