Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disentangle nightly and simd_support feature #1048

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

vks
Copy link
Collaborator

@vks vks commented Sep 22, 2020

Now nightly can be used without implying simd_support. This
hopefully makes the nightly feature more stable and improves
compilation time if simd_support is not required.

The documentation and changelog were updated accordingly.

Fixes #1047.

Now `nightly` can be used without implying `simd_support`. This
hopefully makes the `nightly` feature more stable and improves
compilation time if `simd_support` is not required.

The documentation and changelog were updated accordingly.
@vks
Copy link
Collaborator Author

vks commented Sep 22, 2020

This will also require an update to the Rand book.

The CI does not check whether nightly and simd_support work independently. Should we add this? This would require running the tests two more times, or alternatively running cargo check two times.

@vks
Copy link
Collaborator Author

vks commented Sep 22, 2020

It seems like __m64 was removed from nightly, so maybe we should stop supporting it as well. But maybe that can wait until packed_simd is fixed.

Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes, ideally we should have at least one test of each independently. We could just use different flags on Travis and AppVeyor.

README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation fails with "nightly" feature due to packed-simd dependency
2 participants