Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poisson distribution falls into an infinite loop for parameter λ=∞ #1291

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Poisson distribution falls into an infinite loop for parameter λ=∞ #1291

merged 1 commit into from
Feb 27, 2023

Conversation

Thopic
Copy link
Contributor

@Thopic Thopic commented Feb 24, 2023

Pull request for issue #1290.

dhardy
dhardy reviewed Feb 25, 2023
View reviewed changes
rand_distr/src/poisson.rs Outdated Show resolved Hide resolved
@vks
Copy link
Collaborator

vks commented Feb 25, 2023

Maybe we can also add a test for nan?

@dhardy
Copy link
Member

dhardy commented Feb 27, 2023 •
edited
Loading

@vks this returns NonFinite for both +inf and nan.

Thanks @Thopic.

@dhardy dhardy merged commit 0f3eced into rust-random:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhardy dhardy dhardy approved these changes

@vks vks vks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thopic @vks @dhardy