Debug impls for non-distribution public types #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a problem with the AppVeyor build. It first said "In queue" and has now apparently been "cancelled by user." Maybe @alexcrichton can help? |
|
Yes that's ok, it's just spurious. Thanks! |
pitdicker
pushed a commit
to pitdicker/rand
that referenced
this pull request
Apr 4, 2018
Debug impls for non-distribution public types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #130.
Changes:
#[derive(Debug)]for public types where possible.Type {}debug for remaining public types (OsRng,IsaacRngandIsaac64Rng).#![deny(missing_debug_implementations)]on crate.There are no implementations for the
distributionsmodule as there is already a PR for that. I added a temporary#![allow(missing_debug_implementations)]until it is merged.I figured most types will just need a derive. For those that don't, this can be a good discussion starter. Personally, I'm not sure what to do with the types where derive isn't possible. I don't see any point in exposing 512+ ints for ISAAC, so perhaps
IsaacRng {}is the best we can do.