Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Rand
fori128
andu128
. Some notes:Should
Rng
gain anext_u128
method?This may be desirable in case a
Rng
can directly produce 128 bit wide outputs.Currently
i128
support is enabled using a single feature flag, which may not be the best solution:We probably need two different feature flags in the future: one to enable the
i128
impl
s and one for toggling the#![feature(i128_type)]
(i128_type
will hopefully become stable in the near future, so#![feature(i128_type)]
will not be needed but theimpl
s will still need to be disabled for older rust versions withouti128
support).An alternative would be to automatically enable the features for supporting rust versions using a build script. This would be my preferred solution I think, although I don't know what the policy is for using build scripts like this.
I'm not completely sure about the travis changes.
Fixes #139.
r? @alexcrichton
(If you want the fixme update in a separate PR, please tell me).