Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HTTP links with HTTPS #179

Merged
merged 4 commits into from
Jan 9, 2018
Merged

Replace HTTP links with HTTPS #179

merged 4 commits into from
Jan 9, 2018

Conversation

GabrielMajeri
Copy link
Contributor

This pull request replaces http:// links with https:// links, where possible.

Fixes #166.

@pitdicker pitdicker mentioned this pull request Dec 17, 2017
@dhardy
Copy link
Member

dhardy commented Dec 18, 2017

Needs update, preferably after #209 is merged.

@pitdicker
Copy link
Contributor

@GabrielMajeri Are you willing to rebase this, or shall I do so?

@GabrielMajeri
Copy link
Contributor Author

@pitdicker Done, fixed more links and removed some trailing whitespace.

@dhardy
Copy link
Member

dhardy commented Jan 9, 2018

What are all the whitespace changes for? I like having aligned empty lines. Never mind, I'll merge once CI is happy.

@dhardy dhardy merged commit 0f3c532 into rust-random:master Jan 9, 2018
@GabrielMajeri GabrielMajeri deleted the https branch January 9, 2018 10:38
@GabrielMajeri
Copy link
Contributor Author

@dhardy rustfmt is the one that suggested trimming the whitespace.

@pitdicker
Copy link
Contributor

Wow, quick work!

Eventually I think it would be nice to run rustfmt and clippy on rand, but that should probably wait until the changes from @dhardy's branch and the open PR's are merged.

@dhardy
Copy link
Member

dhardy commented Jan 9, 2018

If you like, just don't hold them up as gold standards. I've disagreed with rustfmt a few times before (including one case where it caused a compile error); Clippy has some great suggestions but also a few that are completely pointless.

pitdicker pushed a commit that referenced this pull request Apr 4, 2018
Replace HTTP links with HTTPS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants