Update documentation for ReadRng error handling #326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will tell you, I hate touching any part of our error handling now 😄. But now it used messages specific for
OsRng
, while that is exactly where it is not used...Actually I was going over the differences between your master branch and current master, to see how far we are with porting over the changes. The documentation of
ReadRng
was one of the small changes missing.When #319 and #320 land there is not much left. Only three things are left:
HighPrecision01
;Choose
andShuffle
;WeightedChoice
.The last two could use some more design work, but I think I can make a PR with the first one. It seems to me a separate distribution
HighPrecisionRange
will do. Then you can also finally track master 🎉.