Use newtypes to get deprecation warnings for compatibility re-exports in 0.6 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
approved these changes
Jun 13, 2018
dhardy
reviewed
Jun 13, 2018
src/deprecated.rs
Outdated
| use std::io::Read; | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| #[deprecated(since="0.5.2", |
There was a problem hiding this comment.
The since bit is now wrong, sorry.
There was a problem hiding this comment.
Someday I'll learn that doing things quickly always causes mistakes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #502 for 0.6.
I want to make another PR to make the changes to
JitterRngwe discussed before. But this is just a basic fix to not get warnings, with no change in functionality (except using a clearly wrong timer intimer_stats). Still not sure why it suddenly started generating some warnings though.