-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace i128_support
feature with compile-time detection
#571
Conversation
i128_support
feature with compile-time detectioni128_support
feature with compile-time detection
I argued against this before (#459) and I'm still not sure it's a good idea. The theoretical disadvantage is that projects may not support older compilers even though they trivially could. In fact, this implementation is worse, in that it completely breaks builds with old nightlies using The status quo is that users needing |
As far as I can tell, this would only apply to nightlies older than 1.26.
It's true that it's not necessary to break those nightlies, but do we really want to commit to supporting old nightlies? Note that in general this is not possible, because supporting new nightlies often means breaking old nightlies. Due to this, I think it is fair to assume that nightlies are at least as young as the latest stable release. (We should document this though.)
It will only become redundant when we enable it by default, resulting in much worse breakage than this PR causes. |
I guess you're right; trying to support old nightlies is ridiculous. Maybe we should never even have allowed the Okay, then this has my approval. We could add a note in the README. We should in the CHANGELOG. I guess it makes sense to leave the dummy feature flag until later and remove in the 0.7 release. Any further comments? Otherwise I'll merge in 1-2 days. |
Should we add "Nightlies older than the last stable version of Rust are not supported." to the README? |
But we can't even guarantee support for nightlies newer than the last stable version... so I don't think that's necessary. Just a note in the changelog here then and we're done? |
This breaks builds using the `i128_support` feature with nightlies supporting `i128` before Rust 1.26.
b79b3b4
to
b7bead9
Compare
I updated the changelog (for a few other changes as well) and rebased on master. |
This breaks builds using the
i128_support
feature with nightliessupporting
i128
before Rust 1.26. I think this is acceptable, unless we want to support very old nightlies.