Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: probe for window not for 'this' #598

Closed
wants to merge 1 commit into from
Closed

Conversation

aep
Copy link

@aep aep commented Aug 30, 2018

fixes #597

@dhardy
Copy link
Member

dhardy commented Aug 31, 2018

Unfortunately we don't really have a maintainer for the WASM code. Please check this which does something a bit different (but doesn't appear to conflict).

Also there's a linker error due to missing libLLVM-7.so. Do you know why — do we need to update cargo-web?

@alexcrichton
Copy link
Contributor

Ah unfortunately I don't think this will work 100% of the time in the sense that window isn't defined in the worker scope on the web, but something like https://github.com/rustwasm/wasm-bindgen/blob/master/crates/test/src/rt/detect.rs I think should work here.

@alexcrichton
Copy link
Contributor

I believe this should be fixed in #600

@dhardy dhardy closed this Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'crypto'
3 participants