Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sized to SampleRange #68

Merged
merged 1 commit into from
Aug 16, 2015
Merged

Conversation

bluss
Copy link
Contributor

@bluss bluss commented Aug 16, 2015

Add Sized to SampleRange

Fix SampleRange for well-formedness warnings on nightly.
See Rust RFC 1214.

This change mirrors the corresponding change in the rust tree.

Fix SampleRange for well-formedness warnings on nightly.
See Rust RFC 1214.

This change mirrors the corresponding change in the rust tree.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bluss
Copy link
Contributor Author

bluss commented Aug 16, 2015

This conflicts with PR #27, but it's a small change.

@alexcrichton
Copy link
Contributor

Thanks!

alexcrichton added a commit that referenced this pull request Aug 16, 2015
@alexcrichton alexcrichton merged commit 1ef6953 into rust-random:master Aug 16, 2015
@bluss bluss deleted the sized-samplerange branch August 16, 2015 16:50
vks pushed a commit to vks/rand that referenced this pull request Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants