rand_os backward compatibility #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@newpavlov thanks for the effort, but it's not just you who doesn't like this approach; I believe run-time errors are preferable for WASM. I pushed this into #686 and also included your second two commits (squashed). Your refactor in the first commit was mixed with the behaviour changes so I left it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#681 #678
This PR returns the old handling of
OsRng, in other words if OS RNG is not supported for given target/features combinations,OsRngis simply left undefined. I personally quite dislike this approach, but it should work as a temporary patch to solve WASM issues.